Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ca certificates to bridge history #1508

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

sbaizet-ledger
Copy link
Member

@sbaizet-ledger sbaizet-ledger commented Aug 27, 2024

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@sbaizet-ledger sbaizet-ledger force-pushed the add-ca-certificates-to-bridge-history branch from ccd5b97 to 5662622 Compare August 27, 2024 14:10
yiweichi
yiweichi previously approved these changes Aug 27, 2024
colinlyguo
colinlyguo previously approved these changes Aug 27, 2024
@yiweichi yiweichi self-requested a review August 27, 2024 14:59
yiweichi
yiweichi previously approved these changes Aug 27, 2024
@sbaizet-ledger sbaizet-ledger merged commit bf48417 into develop Aug 28, 2024
2 checks passed
@sbaizet-ledger sbaizet-ledger deleted the add-ca-certificates-to-bridge-history branch August 28, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants