Remove deprecated Bridge API and add recommended RPC flag #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
isabellewei
commented
Oct 25, 2024
isabellewei
commented
- remove Bridge API endpoint, use Bridge SDK instead
- add gpo flag to node runner guide
✅ Deploy Preview for scroll-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
icemelon
reviewed
Oct 25, 2024
| @@ -68,7 +68,8 @@ Please consider opening port `30303`(UDP & TCP) and enabling discovery so that o | |||
| --datadir "./l2geth-datadir" \ | |||
| --gcmode archive --cache.noprefetch \ | |||
| --http --http.addr "0.0.0.0" --http.port 8545 --http.api "eth,net,web3,debug,scroll" \ | |||
| --l1.endpoint "$L2GETH_L1_ENDPOINT" --rollup.verify | |||
| --l1.endpoint "$L2GETH_L1_ENDPOINT" --rollup.verify \ | |||
| --gpo.congestionthreshold=500 | |||
There was a problem hiding this comment.
The new suggested congestionthreshold should be 200 as discussed at https://scrollco.slack.com/archives/C02PKAQ2430/p1729319394735449?thread_ts=1729291990.648509&cid=C02PKAQ2430
cc @Thegaram
icemelon
reviewed
Oct 25, 2024
| @@ -117,7 +118,8 @@ Running the node in Docker might have a significant impact on node performance. | |||
| --datadir "/volume/l2geth-datadir" \ | |||
| --gcmode archive --cache.noprefetch \ | |||
| --http --http.addr "0.0.0.0" --http.port 8545 --http.api "eth,net,web3,debug,scroll" \ | |||
| --l1.endpoint "$L2GETH_L1_ENDPOINT" --rollup.verify | |||
| --l1.endpoint "$L2GETH_L1_ENDPOINT" --rollup.verify \ | |||
| --gpo.congestionthreshold=500 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.