Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(libzkp): ccc v0.10.2 (enable sha256, remove StructLog.stack) #691

Merged
merged 30 commits into from
Apr 29, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Apr 5, 2024

1. Purpose or design rationale of this PR

Upgrade to v0.10.2, enable sha256, no longer need StructLog.stack.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change

@colinlyguo colinlyguo changed the title enable-sha256 feat(libzkp): enable-sha256 Apr 7, 2024
@lispc lispc changed the title feat(libzkp): enable-sha256 feat(libzkp): upgrade to v0.10.1: enable sha256, no longer need StructLog.stack Apr 10, 2024
@lispc lispc changed the title feat(libzkp): upgrade to v0.10.1: enable sha256, no longer need StructLog.stack feat(libzkp): upgrade to v0.10.1, enable sha256, no longer need StructLog.stack Apr 10, 2024
@colinlyguo colinlyguo marked this pull request as ready for review April 10, 2024 05:58
Copy link
Member

@0xmountaintop 0xmountaintop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cherry-pick 5ebd82e to disable stack

@colinlyguo
Copy link
Member Author

cherry-pick 5ebd82e to disable stack

done.

params/version.go Outdated Show resolved Hide resolved
@Thegaram Thegaram changed the title feat(libzkp): upgrade to v0.10.1, enable sha256, no longer need StructLog.stack feat(libzkp): upgrade to v0.10.2, enable sha256, no longer need StructLog.stack Apr 11, 2024
@Thegaram Thegaram changed the title feat(libzkp): upgrade to v0.10.2, enable sha256, no longer need StructLog.stack feat(libzkp): ccc v0.10.2 (enable sha256, remove StructLog.stack) Apr 11, 2024
@Thegaram Thegaram marked this pull request as draft April 11, 2024 03:33
@colinlyguo colinlyguo changed the base branch from develop to update-codecv1 April 12, 2024 20:12
@colinlyguo colinlyguo changed the base branch from update-codecv1 to develop April 12, 2024 20:12
@colinlyguo colinlyguo changed the base branch from develop to update-codecv1 April 13, 2024 10:09
@colinlyguo colinlyguo changed the base branch from update-codecv1 to develop April 13, 2024 10:10
@Thegaram Thegaram marked this pull request as ready for review April 14, 2024 12:03
@Thegaram Thegaram marked this pull request as draft April 14, 2024 12:07
@Thegaram Thegaram marked this pull request as ready for review April 29, 2024 05:04
@lispc lispc dismissed 0xmountaintop’s stale review April 29, 2024 05:26

i think it is done

@Thegaram Thegaram merged commit 6d80f28 into develop Apr 29, 2024
14 checks passed
@Thegaram Thegaram deleted the new-zkevm branch April 29, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants