Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DON'T MERGE] feat(clique): allow empty block #689

Closed
wants to merge 38 commits into from

Conversation

colinlyguo
Copy link
Member

1. Purpose or design rationale of this PR

Used in some testings.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@colinlyguo colinlyguo marked this pull request as draft April 2, 2024 15:03
@colinlyguo colinlyguo marked this pull request as ready for review April 3, 2024 06:52
@colinlyguo colinlyguo marked this pull request as draft April 3, 2024 07:26
@colinlyguo colinlyguo changed the base branch from develop to new-zkevm April 7, 2024 15:48
@colinlyguo colinlyguo changed the base branch from new-zkevm to develop April 7, 2024 15:49
@colinlyguo colinlyguo changed the base branch from develop to new-zkevm April 12, 2024 08:47
Base automatically changed from new-zkevm to develop April 29, 2024 05:30
@colinlyguo colinlyguo closed this Apr 29, 2024
@0xmountaintop 0xmountaintop deleted the feat-allow-empty-blocks branch August 5, 2024 10:02
@0xmountaintop 0xmountaintop restored the feat-allow-empty-blocks branch August 5, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants