Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.3.0: make read behave like read from base #14

Merged
merged 1 commit into from
Sep 16, 2024
Merged

1.0.3.0: make read behave like read from base #14

merged 1 commit into from
Sep 16, 2024

Conversation

arybczak
Copy link
Contributor

@arybczak arybczak commented Sep 13, 2024 •
edited
Loading

read from base succeeds when there's a single complete parse (and it skips whitespaces) on the list, ours was only succeeding when there was a single item on the list. This doesn't work with the Read instance of UTCTime for example.

@arybczak arybczak force-pushed the correct-read branch 2 times, most recently from 2658273 to 1848f8b Compare September 16, 2024 11:37
@arybczak
1.0.3.0: make read behave like read from base
6ee3923 
read from base succeeds when there's a single complete parse (and it skips
whitespaces) on the list, ours was only succeeding when there was a single item
on the list. This doesn't work with the Read instance of UTCTime for example.
@arybczak arybczak changed the title Make read behave like read from base 1.0.3.0: make read behave like read from base Sep 16, 2024
@arybczak arybczak merged commit 95c9e7f into master Sep 16, 2024
8 checks passed
@arybczak arybczak deleted the correct-read branch September 16, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinelli marinelli marinelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arybczak @marinelli