-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(): when using s3, parse stream output to buffer for html files #117
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ class AwsClient { | |
* @param {String} config.segment S3 segment | ||
* @param {Integer} config.partSize aws-sdk upload option | ||
* @param {Integer} config.httpTimeout HTTP timeout in ms | ||
* @param {String } config.sessionToken Session token for federated AWS login | ||
*/ | ||
constructor(config) { | ||
const options = { | ||
|
@@ -31,6 +32,10 @@ class AwsClient { | |
} | ||
}; | ||
|
||
if (config.sessionToken) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this added for local debugging only? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, any setup with a federated login, not sure if there is a scope to use this to move away from access key based login. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added this, to remove IAM user dependency screwdriver-cd/screwdriver#2454 |
||
options.sessionToken = config.sessionToken; | ||
} | ||
|
||
if (config.endpoint) { | ||
options.endpoint = config.endpoint; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
JSON.stringify
, does JSON.stringify capture many info nosies?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bug with logger we use
winston
This is what we should do long term winstonjs/winston#1338 (comment)