Merge pull request #9 from Gallaecio/full-coverage

Reach 100% coverage and specify which parts are untested in coverage reports

.coveragerc

@@ -1,2 +1,5 @@
 [run]
 branch = true
+
+[report]
+show_missing = true

price_parser/parser.py

@@ -202,6 +202,7 @@ def extract_price_text(price: str) -> Optional[str]:
     return None
 
 
+# NOTE: Keep supported separators in sync with parse_number()
 _search_decimal_sep = re.compile(r"""
 \d           # at least one digit (there can be more before it)
 ([.,€])      # decimal separator
@@ -268,13 +269,15 @@ def parse_number(num: str) -> Optional[Decimal]:
         return None
     num = num.strip().replace(' ', '')
     decimal_separator = get_decimal_separator(num)
+    # NOTE: Keep supported separators in sync with _search_decimal_sep
     if decimal_separator is None:
         num = num.replace('.', '').replace(',', '')
     elif decimal_separator == '.':
         num = num.replace(',', '')
     elif decimal_separator == ',':
         num = num.replace('.', '').replace(',', '.')
-    elif decimal_separator == '€':
+    else:
+        assert decimal_separator == '€'
         num = num.replace('.', '').replace(',', '').replace('€', '.')
     try:
         return Decimal(num)

tests/test_price_parsing.py

@@ -1975,3 +1975,14 @@ def __eq__(self, other):
 def test_parsing(example: Example):
     parsed = Price.fromstring(example.price_raw, example.currency_raw)
     assert parsed == example
+
+
+@pytest.mark.parametrize(
+    "amount,amount_float",
+    (
+        (None, None),
+        (Decimal('1.23'), 1.23),
+    )
+)
+def test_price_amount_float(amount, amount_float):
+    assert Price(amount, None, None).amount_float == amount_float