Use Erik Mollers updated rAF shim. Also fix the Illegal Invocation error... #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -407,7 +419,7 @@ function Survivor() { | |||
| prop: null | |||
| }, | |||
|
|
|||
| 'getAnimationFrame': getAnimationFrame | |||
| 'getAnimationFrame': getAnimationFrame ? getAnimationFrame.bind(window) : null | |||
There was a problem hiding this comment.
Oh wait, this will explode in browsers without Function#bind. If you want, I can throw in a quick shim.
There was a problem hiding this comment.
If you don't mind, that'd be useful; the game does work in IE 8 as-is, FWIW.
|
@scottschiller any chance this pull request can be accepted? |
|
Ah yes, I forgot about this. I'd like it not to break IE 8. Assuming it doesn't, should be cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for Chrome.
Was hoping this would increase perf in Opera (which doesn't have native rAF yet)... but it doesn't seem to. :/
Sooooo... anyways. Maybe this will be useful later if you can figure out why setTimeout is performing so much better than rAF.