Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Commit

Permalink
Merge pull request #9 from scm-spain/feature/add-versiona
Browse files Browse the repository at this point in the history
Feature/add versiona
  • Loading branch information
alextremp authored Jan 10, 2020
2 parents 525b46d + 61cca13 commit 34684d2
Show file tree
Hide file tree
Showing 7 changed files with 33 additions and 6,654 deletions.
37 changes: 13 additions & 24 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,29 +1,18 @@
# Background
## Description
<!--- Explain why this PR has to be merged, what originated this feature, ... -->

X
## Solves ticket/s
<!--- Optionally, add the tickets (jira, mantis, trello, ...) that are related to this PR -->

# Goal
## Expected behavior
<!--- Add information of what's expected to happen when this is merged -->

X
## Review steps
<!--- Nice to have, add the steps you've reproduced for a visual test in your development environment, or loc, consider adding screenshots ... -->

# Implementation
## Further considerations
<!--- If applies, add information of breaking changes, agreed deploy timings, ... -->

X

# Further considerations

X

# Checklist

- [ ] The PR relates to *only* one subject with a clear title.
- [ ] I have performed a self-review of my own code
- [ ] Wrote [good commit messages](http://chris.beams.io/posts/git-commit/)
- [ ] My code is readable by someone else, and I commented the hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works

# Visual description

*your meme goes here*
![](https://media.giphy.com/media/f6pOe5e8ShRhS/giphy.gif)
## Memetized description
<!--- Mandatory gif, try https://giphy.com/ -->
![mandatory]()
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,5 @@ typings/
.env

dist
coverage
coverage
package-lock.json
1 change: 1 addition & 0 deletions .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ coverage
.eslintignore
.github
schibstedspain-openads-appnexus-prebid-*.tgz
versiona.js
7 changes: 5 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@ node_js:
cache:
directories:
- node_modules

before_install:
- npm config set //registry.npmjs.org/:_authToken=$NPM_TOKEN

script:
- npm run lint
- npm test
- npm run check && npm run versiona
- npm run coverage:ci

after_success:
Expand Down
Loading

0 comments on commit 34684d2

Please sign in to comment.