Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub dependency graph #81

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix GitHub dependency graph #81

merged 1 commit into from
Oct 25, 2023

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Oct 24, 2023

This fixes a bug with GitHub's dependency graph, which is currently empty.

More on the issue here: https://github.com/orgs/community/discussions/6456

rgommers
rgommers approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mwtoews! I can't immediately spot the workaround in the linked discussion, but I believe you, CI is green, and it's a sensible change anyway. So in it goes.

@rgommers rgommers merged commit 8d5a313 into scipy:main Oct 25, 2023
21 checks passed
@mwtoews mwtoews deleted the gh-dep-graph-bug branch October 25, 2023 06:59
@mwtoews
Copy link
Contributor Author

mwtoews commented Oct 25, 2023

fix confirmed, see the original link to see a non-empty listing

@rgommers
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwtoews @rgommers