packaging: build rpm packages #4632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
FR4NK-W
reviewed
Oct 8, 2024
Co-authored-by: FR4NK-W <[email protected]>
Co-authored-by: FR4NK-W <[email protected]>
jiceatscion
commented
Oct 8, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 10 files reviewed, 3 unresolved discussions (waiting on @FR4NK-W)
dist/package.bzl line 109 at r2 (raw file):
Previously, FR4NK-W wrote…
# Use the same attributes as scion_pkg_deb, in view of may-be simplifying BUILD.bazel later.
Done.
dist/rpm/scion.postinst line 5 at r2 (raw file):
Previously, FR4NK-W wrote…
adduser --system --gid scion -M -s /sbin/nologin
Done.
FR4NK-W
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Reviewed 1 of 9 files at r1, 2 of 6 files at r2, 1 of 2 files at r4, all commit messages.
Reviewable status: 4 of 10 files reviewed, all discussions resolved
FR4NK-W
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Reviewed 2 of 9 files at r1, 2 of 6 files at r2, 1 of 2 files at r3, 1 of 2 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jiceatscion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the new style rpm_rules (the ones that I find remotely usable) do not appear to support cross-architecture packaging yet. So, this is x86_64 only for now.
Fixes #4425