Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extch 56 bad url crash fix #132

Open
wants to merge 5 commits into
base: EXTCH-23-update-stele-packages
Choose a base branch
from
Open

Extch 56 bad url crash fix #132

wants to merge 5 commits into from

Conversation

tnordberg
Copy link
Member

Thanks for catching this @bryankennedy - the existing code handled hot-reload crashing, but not bad URLs.

I've re-added my fix for bad URLs and tested using http://localhost:3000 in the following scenarios:

  • Prod mode, from initial launch.
  • Prod mode, clicking Save from Settings screen.
  • Dev mode, from initial boot.
  • Dev mode, clicking Save from Settings screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tnordberg