Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added examples for azimuthal and longitudinal properties in 3D and 4D #519

Merged
merged 3 commits into from
Oct 27, 2024

Conversation

pandyah5
Copy link
Contributor

@pandyah5 pandyah5 commented Oct 20, 2024

Description

This PR adds descriptive example to the following properties in /src/vector/backends/numpy.py (Mentioned in #503)

  • Azimuthal - 3D
  • Azimuthal - 4D
  • Longitudinal - 3D
  • Longitudinal - 4D

The demo examples have been run and verified.

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't any other open Pull Requests for the required change?
  • Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • Does your submission pass tests? ($ pytest or $ nox -s tests)
  • Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • Does your submission pass the doctests? ($ pytest --doctest-plus src/vector/ or $ nox -s doctests)

Before Merging

  • Summarize the commit messages into a brief review of the Pull request.

@Saransh-cpp Saransh-cpp self-requested a review October 20, 2024 21:40
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for picking this up, @pandyah5! A few suggestions below -

src/vector/backends/numpy.py Outdated Show resolved Hide resolved
src/vector/backends/numpy.py Outdated Show resolved Hide resolved
src/vector/backends/numpy.py Outdated Show resolved Hide resolved
src/vector/backends/numpy.py Outdated Show resolved Hide resolved
src/vector/backends/numpy.py Outdated Show resolved Hide resolved
src/vector/backends/numpy.py Outdated Show resolved Hide resolved
src/vector/backends/numpy.py Show resolved Hide resolved
src/vector/backends/numpy.py Outdated Show resolved Hide resolved
@pandyah5
Copy link
Contributor Author

pandyah5 commented Oct 27, 2024

Thanks for the feedback @Saransh-cpp! I have addressed all the comments

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To maintain uniformity

src/vector/backends/numpy.py Outdated Show resolved Hide resolved
src/vector/backends/numpy.py Outdated Show resolved Hide resolved
src/vector/backends/numpy.py Outdated Show resolved Hide resolved
src/vector/backends/numpy.py Outdated Show resolved Hide resolved
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the amazing work, @pandyah5!

@Saransh-cpp Saransh-cpp merged commit 2551843 into scikit-hep:main Oct 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants