Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: correct ax.legend() order for stack hists #527

Merged
merged 12 commits into from
Oct 18, 2024
Merged

feat: correct ax.legend() order for stack hists #527

merged 12 commits into from
Oct 18, 2024

Conversation

0ctagon
Copy link
Member

@0ctagon 0ctagon commented Oct 15, 2024 •
edited
Loading

Part of the merging project, linked to this PR in plothist.

@0ctagon
Copy link
Member Author

0ctagon commented Oct 16, 2024 •
edited
Loading

For the failing tests:

  • histplot_real: now has a correct legend order
  • histplot_kwargs: now has a correct legend order
  • histplot_stack: plotting order has changed which modified a few pixels, but no differences

@0ctagon 0ctagon changed the title Correct ax.legend() order for stack hists Feat: correct ax.legend() order for stack hists Oct 18, 2024
@0ctagon
Copy link
Member Author

0ctagon commented Oct 18, 2024

Ready for review @andrzejnovak @jonas-eschle

andrzejnovak
andrzejnovak reviewed Oct 18, 2024
View reviewed changes
src/mplhep/plot.py Outdated Show resolved Hide resolved
andrzejnovak
andrzejnovak reviewed Oct 18, 2024
View reviewed changes
src/mplhep/plot.py Outdated Show resolved Hide resolved
@andrzejnovak andrzejnovak changed the title Feat: correct ax.legend() order for stack hists feat: correct ax.legend() order for stack hists Oct 18, 2024
@andrzejnovak andrzejnovak merged commit 19f9523 into scikit-hep:main Oct 18, 2024
12 checks passed
@0ctagon 0ctagon mentioned this pull request Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrzejnovak andrzejnovak andrzejnovak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0ctagon @andrzejnovak