Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: (.spec-meta) Background for dark-mode #495

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

alphapapa
Copy link
Contributor

@alphapapa alphapapa commented Oct 5, 2023

This fixes the appearance of the .spec-meta class's background color in dark mode.

This should be merged when the theme submodule is updated to include scientific-python/scientific-python-hugo-theme#233.

This supersedes #485.

Tasks

  1. Merge theme update
  2. Rebase and push this PR's branch
  3. Check deploy preview
  4. Merge this PR

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for scientific-python-org ready!

Name Link
🔨 Latest commit 1f15b50
🔍 Latest deploy log https://app.netlify.com/sites/scientific-python-org/deploys/65281cefe75a950008f8044d
😎 Deploy Preview https://deploy-preview-495--scientific-python-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96
Accessibility: 98
Best Practices: 100
SEO: 89
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@alphapapa alphapapa self-assigned this Oct 5, 2023
@alphapapa alphapapa added the bug Something isn't working label Oct 5, 2023
@jarrodmillman jarrodmillman marked this pull request as draft October 6, 2023 09:57
This fixes the appearance of the .spec-meta class's background color
in dark mode.

This should be merged when the theme submodule is updated to include
<scientific-python/scientific-python-hugo-theme#233>.
@jarrodmillman jarrodmillman marked this pull request as ready for review October 12, 2023 19:41
@jarrodmillman jarrodmillman merged commit c1d0e91 into main Oct 12, 2023
5 checks passed
@jarrodmillman jarrodmillman deleted the wip/fix-spec-meta-background branch October 12, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants