Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ToDo with link to Writing documentation in Inline Documentation tutorial #376

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

maxmynter
Copy link
Contributor

@maxmynter maxmynter commented Feb 11, 2024

I found a dangling todo in the inline documentation section which should (I guess?) link to the writing documentation section. Ping me if it should have linked to the topical guide on writing documentation instead (they both have the same name).

You might want to check if the link works correctly. I have some ruby build issues locally and already spend too much time on it for a single line docs fix on a Sunday :) So i could not check it.

Anyways, thanks for building this resource!

@maxmynter maxmynter changed the title Insert link to documentation Replace ToDo with link to Writing documentation in Inline Documentation tutorial Feb 11, 2024
@henryiii
Copy link
Collaborator

@danielballan can comment, I think this might have been referring to #157?

@danielballan
Copy link
Collaborator

I thought so too, at first, but on closer look I think we left this here mid-refactor when the Guide on docs had not yet been put into place.

I think this can be merged.

Copy link
Collaborator

@danielballan danielballan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxmynter!

@henryiii henryiii merged commit f833f3f into scientific-python:main Feb 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants