CI: use File::Temp to create temporary directory #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considering system independence, I would suggest using The chmod function should also be available directly in perl (https://perldoc.perl.org/functions/chmod) |
Before, ci/test-11-unpriv.pl used a hard-coded file name of /tmp/fping.copy to create an unprivileged copy of fping. This file was not deleted after it was no longer used. Now, the unprivileged fping copy is created in a temporary directory that is deleted after all tests from the file. This addresses GH issue schweikert#339.
Before, ci/test-11-unpriv.pl used Perl's "system" function to execute a Unix command line to copy a file and change the permissions of the copy. Now, the Perl functions "copy" (from File::Copy) and "chmod" are used instead.
|
You can merge, everything looks good |
|
Thanks for the review. I'll go ahead and merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, ci/test-11-unpriv.pl used a hard-coded file name of /tmp/fping.copy to create an unprivileged copy of fping. This file was not deleted after it was no longer used.
Now, the unprivileged fping copy is created in a temporary directory that is deleted after all tests from the file.
This addresses GH issue #339.