fix -k, --fwmark with setuid fping executable #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
auerswal
commented
Aug 4, 2024
auerswal
commented
- Setting the SO_MARK socket option requires root privileges (or CAP_NET_ADMIN), thus temporarily elevate privileges for this operation, if possible, by using the p_setsockopt() function. This allows to use -k, --fwmark with setuid fping.
- Adjust README.md since setuid now works for -k, --fwmark.
- Remove "sudo" from testing -k since it is no longer needed.
- Test failure of setting firewall mark without privileges or capabilities for both IPv4 and IPv6.
* Setting the SO_MARK socket option requires root privileges (or CAP_NET_ADMIN), thus temporarily elevate privileges for this operation, if possible, by using the p_setsockopt() function. This allows to use -k, --fwmark with setuid fping. * Adjust README.md since setuid now works for -k, --fwmark. * Remove "sudo" from testing -k since it is no longer needed. * Test failure of setting firewall mark without privileges or capabilities for both IPv4 and IPv6.
|
That looks good |
|
Thanks for the review, I plan to merge this next weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.