Another batch of additional tests (take 2) #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code can only read the TOS byte when using a raw socket. It prints '(TOS unknown)' when a datagram socket is used.
Printing the TOS byte of the received Echo response does not require setting a non-default TOS byte value in the Echo request.
Currently, --print-tos only works with IPv4. In contrast to IPv4, IPv6 raw sockets do not provide access to the raw IP packet. Thus the method used to access the TOS byte value of an IPv4 packet does not work for the TC byte value of an IPv6 packet. This results in always generating '(TOS unknown)' for IPv6 targets.
The tests for --check-source verify that Echo reply packets from a source IP that was not used as the target of the Echo request are not accepted. It does so for default fping, for use with -c, and for use with -C. Test if the source address is really printed without --check-source, but with -c or -C.
Usually, -d gives the same result as -n. Test this. When the target is a name that resolves to an IP, but the IP does not resolve to the same name or any name at all, the output differs. This is harder to test, because this is usually seen as a misconfiguration, so leave this out for now.
The top level domain '.invalid' is reserved for such tests.
|
That's great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested on GNU/Linux. I do not know if it also works on macOS.
Added skipping of two IPv6 tests when IPv6 is not available.