new option --check-source #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the new option --check-source discards Echo reply packets sourced from an address that is different from the specified target address. This can be useful on busy monitoring hosts, because it is possible that two fping processes running at he same time use the same ICMP Echo Reply Identifier for ICMP Echo messages sent to different hosts. This aims to address GH issue schweikert#206.
gsnw
approved these changes
Jul 13, 2024
The long-only options use the character '0' to select the switch
case used to handle the different long-only options. This can be
given as a normal short option that requires an argument:
$ fping -0
fping: option requires an argument -- '0'
see 'fping -h' for usage information
$ fping -0 127.0.0.1 127.0.0.2
127.0.0.2 is alive
Catch this usage error by requiring that one of the long-only
options is given when handling the case of '0'.
|
I do not understand why the test fails on the GitHub CI, it works on my Ubuntu 20.04 system. I am closing this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new option --check-source discards Echo reply packets sourced from an address that is different from the specified target address. This can be useful on busy monitoring hosts, because it is possible that two fping processes running at he same time use the same ICMP Echo Reply Identifier for ICMP Echo messages sent to different hosts.
This aims to address GH issue #206.