Generator limit #331
Merged
Generator limit #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* call freeaddrinfo() before checking the prefix length in add_cidr() * add a comment to the generator limit check in add_range()
As described in GH issue schweikert#299, the MAX_GENERATE+1 limit is only applied when using an address range, not when using CIDR. This commit changes this to always honor the generator limit. * refactor target address generation to use the same new function for both range and CIDR notation * check the limit for addresses to generate in the new function * document the generator limit in "fping --help" output * document the generator limit in the fping man page * test that the address generation limit applies when using CIDR notation
This commit does not add tests that verify the exact limit, because pinging 100000 localhost addresses takes over 15 minutes on my PC. I have tested this fix manually.
schweikert
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses GitHub issue #299 by:
The generator limit is not exactly tested via CI, because pinging 100000 (or 100001) localhost IPv4 addresses takes more than 15 minutes on my computer. Testing 2^17-2 localhost IPv4 addresses takes more than 20 minutes on my computer. Thus I have tested this only manually.