Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some additional tests #329

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Some additional tests #329

merged 2 commits into from
Jun 28, 2024

Conversation

auerswal
Copy link
Collaborator

  • Test that an empty string as option argument is rejected when the option argument needs to be a number.
  • Test that the Unix timestamp produced with -D is not much older than would be expected.

@auerswal
ci: test empty string argument instead of number
51daca0 
Giving an empty string instead of a number as option argument
was not reliably caught, see GH issue schweikert#324 and GH PR schweikert#323.
@auerswal
ci: test timestamp plausibility
c229163 
Some changes of fping resulted in some systems reporting
implausible timestamps, see, e.g., GH issue schweikert#203.  This
commit adds a simplistic plausability check for timestamps
in Unix time format: they need to be greater or equal to
1000000000 (2001-09-09 03:46:40+02:00).
@coveralls
Copy link

Coverage Status

coverage: 85.469%. remained the same
when pulling c229163 on auerswal:more_tests_06
into 94de791 on schweikert:develop.

@auerswal auerswal merged commit 65f00ff into schweikert:develop Jun 28, 2024
9 checks passed
@auerswal auerswal deleted the more_tests_06 branch June 28, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsnw gsnw gsnw approved these changes

@schweikert schweikert schweikert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@auerswal @coveralls @schweikert @gsnw