Some additional tests #327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giving an empty string instead of a number as option argument was not reliably caught, see GH issue schweikert#324 and GH PR schweikert#323.
Sometimes, the macOS CI runner fails one of the loop tests. It seems as if the process is killed before it could finish the output required for the test to pass. So give the test a bit more time between producing output and killing fping.
Some changes of fping resulted in some systems reporting implausible timestamps, see, e.g., GH issue schweikert#203. This commit adds a simplistic plausability check for timestamps in Unix time format: they need to be greater or equal to 1000000000 (2001-09-09 03:46:40+02:00).
|
Hm, the test failing now is one of the tests I tried to make more reliable. Perhaps Those tests should just be skipped on macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new tests check more aspects of
fpingbehavior and make two existing tests a little bit more reliable, but they are not intended to increase code coverage.