Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the variable next_value->ping_ts != 0 in seqmap_add() #307

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

gsnw
Copy link
Contributor

@gsnw gsnw commented Mar 20, 2024

This pull request is a reduced version of @cagney and also fixes error #290 .
With this solution, however, the CPU time is faster than with pull request #306, which also fixes the error

@gsnw
Copy link
Contributor Author

gsnw commented Mar 20, 2024

The error on the test mac is the same error that occurs on azure-pipline with the macOS operating system and the current develop branch. So the cause is probably with github

@schweikert
Copy link
Owner

Thank you for your work on this (exploring multiple fixes, benchmarking) !

@schweikert schweikert merged commit 94e98ac into schweikert:develop Apr 8, 2024
4 of 5 checks passed
@gsnw gsnw deleted the pr/290-reduced branch April 8, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants