Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two code maintenance commits #301

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

auerswal
Copy link
Collaborator

  • some typo fixes regarding ICMP for IPv6 sockets
  • use the already existing function stats_reset_interval()

As mentioned in issue schweikert#300, error messages pertaining to
socket creation may not be printed.  But they should be
corrected anyway, just as the comments.  Having correct
error messages also makes a fix for issue schweikert#300 more
obvious, because the messages itself would not change.
Git commit bb8d71e from 2020 among many
other things introduced the function stats_reset_interval() to reset the
*_i interval (or split) host statistics, but did not use it.  This commit
replaces the open coded reset of interval stats inside print_host_splits()
and print_netdata() with calling stats_reset_interval().
@coveralls
Copy link

Coverage Status

coverage: 84.706% (+0.3%) from 84.423%
when pulling 32661c1 on auerswal:code_maintenance
into d312a27 on schweikert:develop.

@schweikert schweikert merged commit 266eb16 into schweikert:develop Feb 20, 2024
9 checks passed
@auerswal
Copy link
Collaborator Author

Thanks!

@auerswal auerswal deleted the code_maintenance branch February 21, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants