Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Fixed error when sending files to a target directory that didn't exist #836

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sk25469
Copy link

@sk25469 sk25469 commented Nov 10, 2024

  • Fixes Issue #809, which caused errors when attempting to send files or folders located on a different drive letter on Windows systems.

@schollz
Copy link
Owner

schollz commented Nov 10, 2024

does this fix #809? i'm pretty sure #809 can happen even if the out flag is not used

@sk25469
Copy link
Author

sk25469 commented Nov 11, 2024

Sure thanks for letting me know.
I will look for other ways, but can you help here with what other cases it might fail in? We can send to a specific directory only with the --out flag, right?

@schollz
Copy link
Owner

schollz commented Nov 11, 2024

@ymich9963 can provide guidance

@ymich9963
Copy link

Sure I'll try to run it on the same machines and let you know what happens. Do I just use a flag to specify the output or does it get saved in the pwd?

@sk25469
Copy link
Author

sk25469 commented Nov 12, 2024

Can you let me know how you specified the output path earlier in this issue #809?

This PR modifies the following -

  • If you are using an --out flag to specify the output, then it first checks if the output path is valid or not, if it is not valid then it saves it in the pwd.
  • If valid, saves in the desired output directory

You can try running the following to receive in a specific directory -
croc --out /path/to/destination <code-phrase>

@ymich9963
Copy link

I don't remember. I don't think I specified. I was just on the E:/ drive in one PC and on the C:/ drive in another. Could you specify the output for croc before I raised the issue? I remember that it would just output to the same directory as the source.

@ymich9963
Copy link

Should I build from source to test this?

@sk25469
Copy link
Author

sk25469 commented Nov 15, 2024

Yes u should build from source.
Earlier if u used --out and the folder didnt exist, it would just fail.
If u used without the flag, it would just send in the pwd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when sending files/folders on a different drive letter
3 participants