Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to always ignore None in patch #131

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Conversation

krzemin
Copy link
Member

@krzemin krzemin commented Jan 18, 2020

This PR brings flag .ignoreNoneInPatch for patching, requested in #123.

@codecov
Copy link

codecov bot commented Jan 18, 2020

Codecov Report

Merging #131 into master will increase coverage by 0.18%.
The diff coverage is 97.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   95.95%   96.14%   +0.18%     
==========================================
  Files          13       13              
  Lines         495      519      +24     
  Branches       76       71       -5     
==========================================
+ Hits          475      499      +24     
  Misses         20       20
Impacted Files Coverage Δ
...land/chimney/internal/utils/DerivationGuards.scala 98.36% <100%> (ø) ⬆️
...ala/io/scalaland/chimney/internal/PatcherCfg.scala 100% <100%> (ø) ⬆️
.../scalaland/chimney/internal/dsl/PatcherUsing.scala 100% <100%> (ø)
...mney/src/main/scala/io/scalaland/chimney/dsl.scala 80% <100%> (ø) ⬆️
...nd/chimney/internal/macros/TransformerMacros.scala 95.4% <100%> (ø) ⬆️
...laland/chimney/internal/macros/PatcherMacros.scala 96.66% <96.55%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c2d6f...da688ad. Read the comment docs.

@krzemin krzemin changed the base branch from master to feature/incomplete-patches January 18, 2020 19:27
@krzemin krzemin changed the base branch from feature/incomplete-patches to master January 21, 2020 15:18
@krzemin krzemin force-pushed the feature/ignore-nones-in-patch branch from 89f4acf to 2228620 Compare January 21, 2020 15:20
@krzemin krzemin force-pushed the feature/ignore-nones-in-patch branch from 2228620 to 54ffb8b Compare January 21, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants