New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix old dependencies causing 404 errors on initial install #328

Open

ottodevs wants to merge 3 commits into scaffold-eth:challenge-2-token-vendor from ottodevs:fix/old-deps-cause-404

ottodevs commented Sep 7, 2023 •

edited

Loading

Some issues during initial `yarn install`

I investigated the issues preventing yarn install to complete:

Related to old @graphprotocol/graph-cli depending on github.com/hugomrdias/concat-stream that does not exist anymore.
Related to "@nomiclabs/hardhat-ethers": "npm:hardhat-deploy-ethers", that does not found the package.

Solution adopted

Bump both dependencies to latest versions

Observations

I only checked this challenge-2 branch, but probably may affect other branches
The solution is just a patch, a most robust fix would be to update scaffold-eth upstream versions
Not tested since there are no tests, but with this solution it is possible to at least complete challenge-2 that was broken for several weeks/months

Fixes #323


          fixes dependency issues preventing initial install

bb6f580

ottodevs changed the base branch from master to challenge-2-token-vendor

September 7, 2023 06:24

ottodevs changed the title ~~fix/old deps cause 404~~ Fix old dependencies causing 404 errors on initial install

ottodevs added 2 commits

September 7, 2023 09:23


          update other dependencies causing errors

6c31cde


          explicitly use yarn classic

b24202c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet