Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update other packages #960

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Update other packages #960

merged 3 commits into from
Oct 17, 2024

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Oct 10, 2024

Description

Update other minor packages
Point 6 of #917 (comment)

notes:

  • versions of deps from previous update PRs weren't changed
  • qrcode.react has major update here. It works as expected and I think don't need separate pr
  • zustand has 5.0.0rc versions, but I didn't add it because it's just rc
  • if the version of @tanstack/react-query will be fixed when merging this to create-eth (~5.59.8 or 5.59.8), we will need to update @tanstack/react-query inside onchainkit extension. Details: Fix onchainkit create-eth-extensions#30 (comment)

Additional Information

@technophile-04
Copy link
Collaborator

zustand has 5.0.0rc versions, but I didn't add it because it's just rc

Ohh they just released it v5 2 days ago https://github.com/pmndrs/zustand/releases/tag/v5.0.0 should we update it? I think we are not using zustand very hard so it should be easy to migrate? But if its causing a alot of issue we could totally do in different PR 🙌

@rin-st
Copy link
Member Author

rin-st commented Oct 16, 2024

Thanks! Updated zustand and react-query

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! Thanks @rin-st!!

@technophile-04 technophile-04 merged commit 62c4dc9 into main Oct 17, 2024
1 check passed
@technophile-04 technophile-04 deleted the update-deps-minor-versions branch October 17, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants