This repository has been archived by the owner on Jun 7, 2024. It is now read-only.
Test/update options #162
Merged
Test/update options #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures the blockNumberInterval option for hooks actually only updates after correct amount of blocks. For other hooks mocking will be used instead of being this verbose, to speed up test time
Include canary tests that will actually test the update options. All other tests we will just mock instead
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔥 great work! and happy about comments 🥳
just left one feedback about helper.
this test seems to be failing as well
useContractReader Given that a YourContract is deployed Given the setPurpose is called and set with a new value When given opti… given options of block number interval to update; then the hook does not update until that amount of blocks has passed) failed`
testresult.xml
AssertionError: expected 'your purpose' to equal 'no purpose'
at Context. (/home/runner/work/eth-hooks/eth-hooks/test/useContractReader.test.ts:183:48)
useContractReader - When given options of block number interval to update
ssp6
commented
Jan 21, 2022
ssp6
commented
Jan 21, 2022
ssp6
commented
Jan 21, 2022
ssp6
commented
Jan 21, 2022
This comment has been minimized.
This comment has been minimized.
This was referenced Feb 16, 2022
ShravanSunder
pushed a commit
to ShravanSunder/eth-hooks
that referenced
this pull request
Sep 8, 2023
Use the correct prop as a key in Ramp.jsx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the canary tests for update options using:
As dictated in EPIC #118
To get those created also had to create tests for useContractReader (#122 ) and more work on useTokenBalance (#76 )