This repository has been archived by the owner on Sep 16, 2022. It is now read-only.
Migrating address component #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const blockExplorerLink = (address: string, blockExplorer?: string): string => | ||
| `${blockExplorer || 'https://etherscan.io/'}address/${address}`; | ||
|
|
||
| export const useAddress = (props: AddressProps): AddressResult => { |
There was a problem hiding this comment.
I would add tsdocs comments similar to eth-hooks. It helps create automated documentation later. https://scaffold-eth.github.io/eth-hooks/docs/api/modules/Hooks. @stevenpslade
| import { useResolveEnsName } from 'eth-hooks/dapps'; | ||
| import { TEthersProvider } from 'eth-hooks/models'; | ||
|
|
||
| export interface AddressProps { |
There was a problem hiding this comment.
Can we prefix interfaces with I and types with T. it was the standard in eth hooks
| const [ensName] = useResolveEnsName(props.ensProvider, address); | ||
| const explorerLink = blockExplorerLink(address, props.blockExplorer); | ||
|
|
||
| const shortAddress = address ? `${address.substring(0, 5)}...${address.substring(address.length - 4)}` : ''; |
There was a problem hiding this comment.
i think we should check validity of address using ethers.utils
There was a problem hiding this comment.
if invalid, return that in shortAddress
| const shortAddress = address ? `${address.substring(0, 5)}...${address.substring(address.length - 4)}` : ''; | ||
|
|
||
| return { | ||
| shortAddress, |
There was a problem hiding this comment.
shortAddress can be called addressForDisplay
| const blockExplorerLink = (address: string, blockExplorer?: string): string => | ||
| `${blockExplorer || 'https://etherscan.io/'}address/${address}`; | ||
|
|
||
| export const useAddress = (props: AddressProps): AddressResult => { |
There was a problem hiding this comment.
maybe the hook should be called useAddressForDisplay?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Migrate Components and TS-ify
This PR is migrating the Address component from eth-components and Typescript-ifying it.