Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use a github url as extension #143

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Allow to use a github url as extension #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions src/utils/external-extensions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,29 @@ export const getDataFromExternalExtensionArgument = (externalExtension: string)
externalExtension = getArgumentFromExternalExtensionOption(CURATED_EXTENSIONS[externalExtension]);
}

const isGithubUrl = externalExtension.startsWith("https://github.com/");

// Check format: owner/project:branch (branch is optional)
const regex = /^[^/]+\/[^/]+(:[^/]+)?$/;
if (!regex.test(externalExtension)) {
throw new Error(`Invalid extension format. Use "owner/project" or "owner/project:branch"`);
if (!regex.test(externalExtension) && !isGithubUrl) {
throw new Error(`Invalid extension format. Use "owner/project", "owner/project:branch" or github url.`);
}

// Extract owner, project and branch
const owner = externalExtension.split("/")[0];
const project = externalExtension.split(":")[0].split("/")[1];
const branch = externalExtension.split(":")[1];
let owner;
let project;
let branch;

if (isGithubUrl) {
// Extract owner, project and branch from github url
owner = externalExtension.split("/")[3];
project = externalExtension.split("/")[4];
branch = externalExtension.split("/tree/")[1];
} else {
// Extract owner, project and branch from owner/project:branch
owner = externalExtension.split("/")[0];
project = externalExtension.split(":")[0].split("/")[1];
branch = externalExtension.split(":")[1];
}

const githubUrl = `https://github.com/${owner}/${project}`;
let githubBranchUrl;
Expand Down
Loading