Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forking url for foundry #141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

moltam89
Copy link

Hey guys,

Currently foundry uses the public mainnet RPC for forking, which can be problematic, see scaffold-eth#955 (comment).

Hardhat already uses the FORKING_URL environment variable.

Note:
I might have had to send this PR to https://github.com/scaffold-eth/scaffold-eth-2/tree/foundry, but this branch seems to be older than this repo (still uses alchemy API key).

Cheers,
Tamas

@technophile-04
Copy link
Collaborator

I might have had to send this PR to https://github.com/scaffold-eth/scaffold-eth-2/tree/foundry, but this branch seems to be older than this repo (still uses alchemy API key).

Ohh yeah, @moltam89 do you want to update that branch with alchemy key changes and also add this changes to that PR? Ideally we are trying to keep that branch and this sync for now 🙌

@moltam89
Copy link
Author

Yeah, I'll look into this (probably next week) and try to apply the changes from here to the scaffold-eth-2/foundry branch.

@technophile-04
Copy link
Collaborator

Thanks Tam! I just updated the SE-2 foundry branch with (alchemy stuff) but can make this PR changes to SE-2 foundry

@moltam89
Copy link
Author

Thanks @technophile-04 !

Here is the SE2 version of this:scaffold-eth#974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants