-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template support for solidityVersion, networks and tailwind extend #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Tested and everything is working!
Update: not everything :) If no |
templates/solidity-frameworks/hardhat/packages/hardhat/hardhat.config.ts.template.mjs
Outdated
Show resolved
Hide resolved
templates/solidity-frameworks/hardhat/packages/hardhat/hardhat.config.ts.template.mjs
Outdated
Show resolved
Hide resolved
Thanks Rinat, good catch!! Should be fixed here: 0932d22 (used && instead of ternary, I think it should be fine in this case and nothing like "false" should get printed) (I'm sure we had a good reason for it, but having some of these values as arrays (e.g. solidityVersion) is a bit confusing.... and then when we add the default at the bottom of the file, it's just a string :() |
Yes, I also noticed that it's not so good. As I remember, it's because theoretically when using multiple extensions, some of those extensions could have same variables. So they'd be collected into arrays. I'll play with it next days at least to know the code better. Not sure I'll change something :) |
templates/solidity-frameworks/hardhat/packages/hardhat/hardhat.config.ts.template.mjs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @carletex also Rinat for review!! Works great!
Since we already have those files (hardhat & tailwind config) on a template, I wonder if we should add some handy stuff.
You can test with https://github.com/carletex/create-eth-extensions/tree/tailwind-extend-solidity-version
What do you think?
(I'll add the changeset if we like this)