Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace problem for array schema elements and respect XML schem… #802

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

warnickr
Copy link

…a sequence ordering

@warnickr
Copy link
Author

Looks like I need to add an additional test to avoid the decrease in coverage.

@warnickr
Copy link
Author

warnickr commented May 5, 2017

Reverted bad patch for array handling. The patch for XML schema ordering works well for my use.

@atz
Copy link

atz commented Feb 7, 2018

This affects our integration. Ruby Hash default key order ends up determining the XML of the request instead of the governing WSDL document's xs:sequence. See: #859

@stale
Copy link

stale bot commented Apr 9, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 9, 2018
@stale
Copy link

stale bot commented Apr 16, 2018

This issue is now closed due to inactivity. If you believe this needs further action, please re-open to discuss.

@stale stale bot closed this Apr 16, 2018
@pcai pcai reopened this May 10, 2018
@pcai
Copy link
Member

pcai commented May 10, 2018

@warnickr thanks for your contribution, and apologies this went unreviewed so long. I think I understand this change. Would you be able to add some specs to cover this scenario?

@warnickr
Copy link
Author

It may take me a few weeks to get to it, but I will merge in the latest and add some specs.

@pcai
Copy link
Member

pcai commented May 11, 2018

Thank you for your persistence and your help.

@pcai pcai removed the wontfix label May 12, 2018
@hlascelles
Copy link

We've been bitten by this as well. I'm not that familiar with Gyoku etc. Is this PR still active?

@gtoroap
Copy link

gtoroap commented Dec 28, 2018

I'm not sure why this PR is not merged yet. Can we have some advances on this topic? I'm requiring this on a project.

@hlascelles
Copy link

@warnickr do you need to share the burden? This seems like a vital update to a commonly used tool.

@hlascelles
Copy link

This is still an issue for us. What do people think @pcai @olleolleolle?

@olleolleolle
Copy link
Contributor

The current state is: the change needs specs.

Any effort to add specs is welcome, even only a description in words (a PR to the PR would be even easier to use).

@pcai
Copy link
Member

pcai commented Oct 1, 2024

This PR is still not eligible to merge because it doesn't have any accompanying tests, and it also has a merge conflict with main.

I tried to update it and add a synthetic test, but I'm not very confident it has been tested correctly. I encountered several issues from testing and I believe they are addressed, but I don't have an example WSDL to test against.

Can someone verify if this commit (based on main branch) addresses their issue?: 7351ccd

Can someone provide a WSDL and example operation where this is an issue? This would help with testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants