Rename mapconcrete to mapnode #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judofyr
previously approved these changes
Aug 23, 2024
sgulseth
force-pushed
the
feat/typeevaluator/handle-unknowns
branch
from
dc23a98
to
0983680
Compare
An error occurred while trying to automatically change base from
feat/typeevaluator/handle-unknowns
to
main
August 23, 2024 11:03
sgulseth
force-pushed
the
refactor/typeevaluator/rename-mapconcrete
branch
from
3eb2f48
to
daf1eab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapNode is more precise as it doesn't always return a concrete type any more