fix(typeEvaluator): fix in-operator union handling #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgulseth
force-pushed
the
fix/conditional-in-operator
branch
from
cd4bcf7
to
aedb463
Compare
tzhelyazkova
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
looks good to me but maybe @judofyr also wants to take a look?
|
Closing in favor of #256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't handling union with nulls properly. This reduces over the lhs/rhs on opcall nodes when evaluating conditions
Fixes sanity-io/sanity#6628