feat: can extract attribute key from Group

sanity-io · Feb 21, 2024 · c1526c9 · c1526c9
1 parent 2da36d8
commit c1526c9
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 10 deletions.
diff --git a/src/parser.ts b/src/parser.ts
@@ -839,7 +839,8 @@ function extractPropertyKey(node: ExprNode): string {
     node.type === 'Slice' ||
     node.type === 'Filter' ||
     node.type === 'AccessElement' ||
-    node.type === 'ArrayCoerce'
+    node.type === 'ArrayCoerce' ||
+    node.type === 'Group'
   ) {
     return extractPropertyKey(node.base)
   }

diff --git a/tap-snapshots/test/parse.test.ts.test.cjs b/tap-snapshots/test/parse.test.ts.test.cjs
@@ -158,9 +158,7 @@ Object {
 }
 `
 
-exports[
-  `test/parse.test.ts TAP Basic parsing Object expression starting with string > must match snapshot 1`
-] = `
+exports[`test/parse.test.ts TAP Basic parsing Object expression starting with string > must match snapshot 1`] = `
 Object {
   "attributes": Array [
     Object {
@@ -187,9 +185,7 @@ Object {
 }
 `
 
-exports[
-  `test/parse.test.ts TAP Basic parsing Space after field in objects > must match snapshot 1`
-] = `
+exports[`test/parse.test.ts TAP Basic parsing Space after field in objects > must match snapshot 1`] = `
 Object {
   "attributes": Array [
     Object {
@@ -205,9 +201,7 @@ Object {
 }
 `
 
-exports[
-  `test/parse.test.ts TAP Basic parsing Trailing comma in function call > must match snapshot 1`
-] = `
+exports[`test/parse.test.ts TAP Basic parsing Trailing comma in function call > must match snapshot 1`] = `
 Object {
   "alternatives": Array [],
   "fallback": Object {
@@ -217,3 +211,34 @@ Object {
   "type": "Select",
 }
 `
+
+exports[`test/parse.test.ts TAP Expression parsing when extracting property keys can extract from group > must match snapshot 1`] = `
+Object {
+  "base": Object {
+    "type": "Everything",
+  },
+  "expr": Object {
+    "base": Object {
+      "type": "This",
+    },
+    "expr": Object {
+      "attributes": Array [
+        Object {
+          "name": "id",
+          "type": "ObjectAttributeValue",
+          "value": Object {
+            "base": Object {
+              "name": "id",
+              "type": "AccessAttribute",
+            },
+            "type": "Group",
+          },
+        },
+      ],
+      "type": "Object",
+    },
+    "type": "Projection",
+  },
+  "type": "Map",
+}
+`
diff --git a/test/parse.test.ts b/test/parse.test.ts
@@ -134,6 +134,10 @@ t.test('Expression parsing', async (t) => {
     t.test('throws when the key cannot be determined', async (t) => {
       throwsWithMessage(t, () => parse('*{1}'), 'Cannot determine property key for type: Value')
     })
+
+    t.test('can extract from group', async (t) => {
+      t.matchSnapshot(parse('*{(id)}'))
+    })
   })
 
   t.test('when parsing operators', async (t) => {