Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom name generation #2961

Merged
merged 6 commits into from
Jun 23, 2024
Merged

Allow for custom name generation #2961

merged 6 commits into from
Jun 23, 2024

Conversation

ahopkins
Copy link
Member

Replaces #2928

While I appreciate the work that @hamedsh did in the previous PR, I think this more closely aligns with Sanic in allowing the name generation to be overriden and not specifying exactly how. It leads to a simpler API.

@ahopkins ahopkins requested a review from a team as a code owner June 23, 2024 08:19
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.651%. Comparing base (33bc520) to head (aa49ec9).
Report is 4 commits behind head on main.

Current head aa49ec9 differs from pull request most recent head c549866

Please upload reports for the commit c549866 to get more accurate results.

Files Patch % Lines
sanic/mixins/base.py 90.909% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2961       +/-   ##
=============================================
+ Coverage   87.640%   87.651%   +0.011%     
=============================================
  Files          101       101               
  Lines         7573      7572        -1     
  Branches      1329      1328        -1     
=============================================
  Hits          6637      6637               
+ Misses         641       639        -2     
- Partials       295       296        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahopkins ahopkins merged commit b8cf4b2 into main Jun 23, 2024
25 checks passed
@ahopkins ahopkins deleted the name-generator branch June 23, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant