chore: address new linter issues

salesforce · Oct 1, 2024 · 996bb03 · 996bb03
1 parent 6dcaa5c
commit 996bb03
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/lib/__tests__/cookieJar.spec.ts b/lib/__tests__/cookieJar.spec.ts
@@ -400,8 +400,8 @@ describe('CookieJar', () => {
           'http://other.example.com': ['other=qq; Path=/'],
           'http://other.example.com/foo': ['other2=qq; Path=/foo'],
         }
-        for await (const [url, cookies] of Object.entries(cookiesByUrl)) {
-          for await (const cookie of cookies) {
+        for (const [url, cookies] of Object.entries(cookiesByUrl)) {
+          for (const cookie of cookies) {
             await cookieJar.setCookie(cookie, url)
           }
         }
@@ -995,8 +995,8 @@ describe('CookieJar', () => {
           Cookie.parse('foo=bar; Domain=foo.com; Path=/'),
         ],
       }
-      for await (const [path, cookies] of Object.entries(cookiesByDomain)) {
-        for await (const cookie of cookies) {
+      for (const [path, cookies] of Object.entries(cookiesByDomain)) {
+        for (const cookie of cookies) {
           await cookieJar.setCookie(cookie as Cookie, path)
         }
       }

diff --git a/lib/__tests__/jarSerialization.spec.ts b/lib/__tests__/jarSerialization.spec.ts
@@ -185,8 +185,8 @@ describe('cookieJar serialization', () => {
       // getAllCookies to be exercised.
       const paths = ['/', '/foo', '/foo/bar']
       const domains = ['example.com', 'www.example.com', 'example.net']
-      for await (const path of paths) {
-        for await (const domain of domains) {
+      for (const path of paths) {
+        for (const domain of domains) {
           const key = 'key'
           const value = JSON.stringify({ path, domain })
           const cookie = new Cookie({ expires, domain, path, key, value })

diff --git a/lib/cookie/cookieJar.ts b/lib/cookie/cookieJar.ts
@@ -346,7 +346,7 @@ export class CookieJar {
     let syncResult: T | undefined = undefined
 
     try {
-      fn.call(this, (error: Error | null, result?: T | undefined) => {
+      fn.call(this, (error: Error | null, result?: T) => {
         syncErr = error
         syncResult = result
       })
@@ -809,10 +809,7 @@ export class CookieJar {
    * @param url - The domain to store the cookie with.
    * @param options - Configuration settings to use when retrieving the cookies.
    */
-  getCookies(
-    url: string | URL,
-    options?: GetCookiesOptions | undefined,
-  ): Promise<Cookie[]>
+  getCookies(url: string | URL, options?: GetCookiesOptions): Promise<Cookie[]>
   /**
    * @internal No doc because this is an overload that supports the implementation
    */