Fix ChatView TableView crash when scrolling to bottom #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasmustautsglia
requested review from
igorkravchenko,
gersonnoboa,
EgorovEI and
yurii-glia
|
!squash |
This PR resolves a race condition that caused a crash when scrolling to the bottom. The issue stemmed from outdated section row count data, leading the system to believe a section had rows when, in actuality, it didn't. MOB-2578
sm-deployer
force-pushed
the
Fix-TableView-crash-when-scrolling-to-bottom
branch
from
d036829
to
642663e
Compare
gersonnoboa
approved these changes
Aug 25, 2023
EgorovEI
approved these changes
Aug 25, 2023
rasmustautsglia
deleted the
Fix-TableView-crash-when-scrolling-to-bottom
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a race condition that caused a crash when scrolling to the bottom. The issue stemmed from outdated section row count data, leading the system to believe a section had rows when, in actuality, it didn't.
This PR also removes the method
scrollToTopas it wasn't used anywhereMOB-2578