Discard duplicate messages delivered by sockets #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When messages from history are loaded, same messages delivered from sockets are to be discarded to avoid duplicates. MOB-2542
igorkravchenko
requested review from
gersonnoboa,
EgorovEI,
rasmustautsglia and
yurii-glia
yurii-glia
reviewed
Aug 18, 2023
There was a problem hiding this comment.
@igorkravchenko to avoid having business logic on Widgets side perhaps it makes sense to do this logic on Core SDK side, would it make sense and possible to do?
@yurii-glia On Core SDK side we do not have currently interface that would combine getting messages from history and from sockets at once. This is attempted in Widgets for specific cases. |
yurii-glia
approved these changes
Aug 18, 2023
rasmustautsglia
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When messages from history are loaded, same messages delivered from sockets are to be discarded to avoid duplicates.
MOB-2542