Fix dark mode issues in GVA #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasmustautsglia
requested review from
yurii-glia,
gersonnoboa,
igorkravchenko and
EgorovEI
yurii-glia
reviewed
Aug 14, 2023
| @@ -66,6 +66,10 @@ final class GvaGalleryListView: BaseView { | |||
| ).activate() | |||
| } | |||
|
|
|||
| override func defineLayout() { | |||
| collectionView.backgroundColor = UIColor.clear | |||
There was a problem hiding this comment.
super.defineLayout()missed super call.
There was a problem hiding this comment.
fixed b613e53
gersonnoboa
reviewed
Aug 14, 2023
| @@ -59,6 +59,18 @@ final class QuickReplyView: BaseView { | |||
| collectionView.trailingAnchor.constraint(equalTo: safeAreaLayoutGuide.trailingAnchor) | |||
| ]) | |||
| } | |||
|
|
|||
| override func layoutSubviews() { | |||
| switch style.backgroundColor { | |||
There was a problem hiding this comment.
Doesn't layoutSubviews also need super? @yurii-glia
There was a problem hiding this comment.
It does indeed
There was a problem hiding this comment.
fixed 5c4854f
There was a problem hiding this comment.
for consistency yes, however, afaik, Apple doc for layoutSubviews method mentions that it is not necessary to call super for this method.
EgorovEI
approved these changes
Aug 14, 2023
yurii-glia
approved these changes
Aug 14, 2023
gersonnoboa
approved these changes
Aug 14, 2023
igorkravchenko
approved these changes
Aug 14, 2023
|
!squash |
Some of the views were rendered differently in dark mode, and needed some adjustments.
sm-deployer
force-pushed
the
Fix-dark-mode-issues-in-GVA
branch
from
5c4854f
to
36a1061
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the views were rendered differently in dark mode, and needed some adjustments.