Add Snapshot tests for GVA response text #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasmustautsglia
requested review from
igorkravchenko,
gersonnoboa and
yurii-glia
gersonnoboa
approved these changes
Aug 9, 2023
| @@ -63,10 +63,6 @@ class ChatMessageView: BaseView { | |||
| ) | |||
| contentView.attributedText = text | |||
| contentView.linkTapped = { [weak self] in self?.linkTapped?($0) } | |||
| contentView.accessibilityProperties = .init( | |||
There was a problem hiding this comment.
Is there a reason this was removed?
There was a problem hiding this comment.
This implementation is applicable only to a normal message, and not to an attributed message. Removing that was essential for the accessibility to be displayed properly
|
!squash |
This PR adds snapshot tests for GVA response text. MOB-2509
sm-deployer
force-pushed
the
Add-snapshot-tests-for-gva-response-text
branch
from
2af0107
to
dae73ab
Compare
yurii-glia
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds snapshot tests for GVA response text.
MOB-2509