Cover GVA persistent button with snapshot tests #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasmustautsglia
requested review from
igorkravchenko,
gersonnoboa,
EgorovEI and
yurii-glia
rasmustautsglia
force-pushed
the
Cover-GVA-Persistent-button-with-snapshot-tests
branch
from
3699f99
to
0811218
Compare
EgorovEI
reviewed
Aug 4, 2023
GliaWidgets/Sources/View/Chat/Message/Content/Text/ChatTextContentView.swift
Outdated
Show resolved
Hide resolved
EgorovEI
approved these changes
Aug 4, 2023
gersonnoboa
reviewed
Aug 4, 2023
GliaWidgets/Sources/ViewController/Chat/ChatViewController.Mock.swift
Outdated
Show resolved
Hide resolved
gersonnoboa
approved these changes
Aug 4, 2023
yurii-glia
approved these changes
Aug 4, 2023
This PR covers Persistent button with VoiceOver and Layout snapshot tests. However, due to complications, dynamic font snapshot tests are not working as expected and will be postponed until later in order to maximise progress with the project. Rest assured, dynamic font in attributed string works well in simulator and in real device. This PR also utilizes textstyle as a key component in making attributed string scale with dynamic font. Because of that, no default value is provided in the styles for textStyle anymore. MetadataWrapper is necessary for making proper metadata json, as the nature of the Metadata type is somewhat restrictive. MOB-2375
rasmustautsglia
force-pushed
the
Cover-GVA-Persistent-button-with-snapshot-tests
branch
from
a001d9c
to
56898cf
Compare
rasmustautsglia
deleted the
Cover-GVA-Persistent-button-with-snapshot-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers Persistent button with VoiceOver and Layout snapshot tests. However, due to complications, dynamic font snapshot tests are not working as expected and will be postponed until later in order to maximise progress with the project. Rest assured, dynamic font in attributed string works well in simulator and in real device.
This PR also utilizes textstyle as a key component in making attributed string scale with dynamic font. Because of that, no default value is provided in the styles for textStyle anymore.
MetadataWrapper is necessary for making proper metadata json, as the nature of the Metadata type is somewhat restrictive.
MOB-2375