Add translation layer from new strings to old string #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gersonnoboa
requested review from
rasmustautsglia,
igorkravchenko,
EgorovEI and
yurii-glia
EgorovEI
approved these changes
Aug 4, 2023
igorkravchenko
approved these changes
Aug 4, 2023
rasmustautsglia
approved these changes
Aug 4, 2023
|
Bitrise is failing because with the changed strings, the snapshot tests fail. Created a PR for that https://github.com/salemove/ios-widgets-snapshots/pull/28 |
yurii-glia
approved these changes
Aug 4, 2023
|
!squash |
In the new list of strings unified between iOS and Android, there are some strings that have changed their name. However, the string itself is the same. Thus, there's a layer that converts between these new strings and the old strings. These aren't used anywhere yet. However, subsequent pull requests will put them to use. The idea is to have those old strings deprecated and only use the new ones, and then delete this layer in a year, just keeping the new ones in use. Also some strings were changed already if the change was really small and new strings that didn't have an equivalent before were added. MOB-2492
|
!merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new list of strings unified between iOS and Android, there are some strings that have changed their name. However, the string itself is the same. Thus, there's a layer that converts between these new strings and the old strings. These aren't used anywhere yet. However, subsequent pull requests will put them to use. The idea is to have those old strings deprecated and only use the new ones, and then delete this layer in a year, just keeping the new ones in use.
Also some strings were changed already if the change was really small and new strings that didn't have an equivalent before were added.
MOB-2492