Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devs want to deprecate iOS 13 support #1107

Open
wants to merge 1 commit into
base: feature/entry-widget-and-secure-conversations-v2
Choose a base branch
from
Open

Devs want to deprecate iOS 13 support #1107

wants to merge 1 commit into from
+8 −7

Conversation

AndriiHorishniiMOC
Copy link

What was solved?
Remove iOS 13 support.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

@AndriiHorishniiMOC AndriiHorishniiMOC changed the base branch from master to feature/entry-widget-and-secure-conversations-v2 November 6, 2024 19:21
igorkravchenko
igorkravchenko approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to reword "Devs want to deprecate iOS 13 support" to "Bump up deployment target from iOS 13 to 14"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasmustautsglia rasmustautsglia rasmustautsglia approved these changes

@igorkravchenko igorkravchenko igorkravchenko approved these changes

@ykyivskyi-gl ykyivskyi-gl Awaiting requested review from ykyivskyi-gl

@EgorovEI EgorovEI Awaiting requested review from EgorovEI

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriiHorishniiMOC @igorkravchenko @rasmustautsglia