Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize using of strings for the Entry Widget #1105

Conversation

AndriiHorishniiMOC
Copy link

@AndriiHorishniiMOC AndriiHorishniiMOC commented Nov 4, 2024

MOB-3753

What was solved?
Optimized use of strings for the Entry Widget:

  • Removed computed properties for title, subtitle, and hint from the MediaTypeItem.
  • Added properties for the title, subtitle, and hint for each media type to the Entry Widget Style structures.
  • Added functions that return the title, subtitle, and hint for the MediaTypeItem.
  • Functions from the Entry Widget Style structures in the EntryWidgetView were used to display strings.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKsThings to consider for newly added logs in Confluence for more information.

Screenshots:

- Remove computed properties for title, subtitle, and hint from the MediaTypeItem.
- Add properties for the title, subtitle, and hint for each media type to the Entry Widget Style structures.
- Add functions that return the title, subtitle, and hint for the MediaTypeItem.
- Use functions from the Entry Widget Style structures in the EntryWidgetView to display strings.

MOB-3753
Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AndriiHorishniiMOC AndriiHorishniiMOC merged commit 50f856e into feature/entry-widget-and-secure-conversations-v2 Nov 6, 2024
8 checks passed
@AndriiHorishniiMOC AndriiHorishniiMOC deleted the MOB-3753_entry_widget_optimization branch November 6, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants