Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote config for Leave Current Conversation dialog #1094

Conversation

EgorovEI
Copy link
Contributor

MOB-3737

What was solved?
This commit:

  • Extends RemoteConfiguration.AlertStyle with negativeNeutralButton (screenshot 1)
  • fixes missed applying buttons alignment in alerts (screenshot 2)

Note: Snapshot test will be added in next PR

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKsThings to consider for newly added logs in Confluence for more information.

Screenshots:
Simulator Screenshot - iPhone 15 - 2024-10-25 at 14 09 51 Simulator Screenshot - iPhone 15 - 2024-10-25 at 14 13 01

This commit:
 - Extends RemoteConfiguration.AlertStyle with negativeNeutralButton
 - fixes missed applying buttons alignment in alerts

MOB-3737
Copy link
Contributor

@ykyivskyi-gl ykyivskyi-gl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EgorovEI EgorovEI merged commit 60c32ae into feature/entry-widget-and-secure-conversations-v2 Oct 25, 2024
8 checks passed
@EgorovEI EgorovEI deleted the task/MOB-3737-leave-conversation-dialog-remote-config branch October 25, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants