Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement unified customization for SC bottom banner #1090

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Implement unified customization for SC bottom banner #1090

merged 1 commit into from
Oct 24, 2024

Conversation

igorkravchenko
Copy link
Contributor

Add unified customization implementation for SC bottom banner.

MOB-3717

What was solved?

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

EgorovEI
EgorovEI reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@EgorovEI EgorovEI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to get rid of linter warning in ChatStyle.apply method

GliaWidgets/Sources/View/Chat/SecureMessagingBottomBannerViewStyle.RemoteConfig.swift Outdated Show resolved Hide resolved
GliaWidgets/Sources/View/Chat/SecureMessagingBottomBannerViewStyle.RemoteConfig.swift Outdated Show resolved Hide resolved
GliaWidgets/Sources/View/Chat/SecureMessagingBottomBannerViewStyle.RemoteConfig.swift Outdated Show resolved Hide resolved
ykyivskyi-gl
ykyivskyi-gl approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@ykyivskyi-gl ykyivskyi-gl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just optional suggestions.

GliaWidgets/Sources/View/Chat/SecureMessagingBottomBannerViewStyle.RemoteConfig.swift Outdated Show resolved Hide resolved
GliaWidgets/Sources/View/Chat/SecureMessagingBottomBannerViewStyle.RemoteConfig.swift Outdated Show resolved Hide resolved
@igorkravchenko igorkravchenko force-pushed the task/MOB-3717-bottom-banner-unified-customization branch 3 times, most recently from be4b8e7 to 4fe3105 Compare October 24, 2024 10:36
@igorkravchenko
Copy link
Contributor Author

!squash

@igorkravchenko
Implement unified customization for SC bottom banner
ca3f78c 
Add unified customization implementation for SC bottom banner.

MOB-3717
@sm-deployer sm-deployer force-pushed the task/MOB-3717-bottom-banner-unified-customization branch from 4fe3105 to ca3f78c Compare October 24, 2024 12:24
@igorkravchenko igorkravchenko merged commit 1164336 into feature/entry-widget-and-secure-conversations-v2 Oct 24, 2024
8 checks passed
@igorkravchenko igorkravchenko deleted the task/MOB-3717-bottom-banner-unified-customization branch October 24, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykyivskyi-gl ykyivskyi-gl ykyivskyi-gl approved these changes

@EgorovEI EgorovEI EgorovEI approved these changes

@rasmustautsglia rasmustautsglia Awaiting requested review from rasmustautsglia

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorkravchenko @EgorovEI @ykyivskyi-gl